Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release version 1.17.0 #169

Closed
joakime opened this issue Aug 21, 2024 · 7 comments · Fixed by #170
Closed

Please release version 1.17.0 #169

joakime opened this issue Aug 21, 2024 · 7 comments · Fixed by #170

Comments

@joakime
Copy link
Contributor

joakime commented Aug 21, 2024

Is your feature request related to a problem? Please describe.
Need new release with fixes from

Describe the solution you'd like
A release I can use with those fixes

Describe alternatives you've considered
Forking this repo and making a publishing a release under a different groupId on maven central.

Additional context
See:

[ERROR] /home/jenkins/agent/workspace/jetty.project_PR-12075/jetty-core/jetty-compression/jetty-compression-brotli/src/main/java/org/eclipse/jetty/compression/brotli/BrotliEncoderSink.java:[151,43] com.aayushatharva.brotli4j.encoder.EncoderJNI.Operation is not public in com.aayushatharva.brotli4j.encoder.EncoderJNI; cannot be accessed from outside package

@hyperxpro
Copy link
Owner

I will cut release the tonight.

@hyperxpro hyperxpro linked a pull request Aug 21, 2024 that will close this issue
@joakime
Copy link
Contributor Author

joakime commented Aug 21, 2024

I have a workaround in place right now, but it is really just a temporary hack that isn't very JPMS friendly.

jetty/jetty.project@5ba1c5d

So, please don't feel rushed, if it take a couple of weeks, no big deal.
It is more important that the release is done with care then done with speed.

@hyperxpro
Copy link
Owner

It's alright mate, I had the release ready but I was busy figuring out build failures of #163. That said, I will just release it in the next 1 hour, the build is already in progress.

My next milestone is to automate the release pipeline, right now I do it manually from a VM.

@hyperxpro
Copy link
Owner

Released, syncing to Maven now.

@joakime
Copy link
Contributor Author

joakime commented Aug 21, 2024

Confirmed to exist on maven central now - https://repo1.maven.org/maven2/com/aayushatharva/brotli4j/brotli4j/1.17.0/

@hyperxpro
Copy link
Owner

Great to see Jetty finally bringing Brotli! :)

@joakime
Copy link
Contributor Author

joakime commented Aug 21, 2024

Alrighty, got Jetty upgraded to 1.17.0!

jetty/jetty.project@00b2992

Thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants