-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass thread priority setting into NameableThreadFactory constructor #190
Comments
Thanks for reporting and explaining everything so well. I appreciate that. This would spare me some time fixing all of that by myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've hooked into the D-Bus using 4.2.1 as follows:
The call to
withSignalThreadPriority
performs:That call assigns the thread priority:
The signal thread priority doesn't appear to be used because the
getSignalThreadPriority()
method isn't invoked.Within the constructor for
ReceivingService
, a newNameableThreadFactory
instance is added to the internalexecutors
map:The
ReceivingService
invokes the two-argument constructor forNameableThreadFactory
, which uses a default priority ofThread.NORM_PRIORITY
:Does the
ReceivingService
constructor need to call a differentNameableThreadFactory
constructor? That is, the one that takes the thread priority? Such as by calling_rsCfg.getSignalThreadPriority()
:Also, do we need to pass in the priority for the sending side? That is, in
AbstractConnection
:Does that need to pass
_rsCfg.getSignalThreadPriority()
as well?The text was updated successfully, but these errors were encountered: