Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new toast-like notification that is displayed when there are pending updates #6255

Closed
10 tasks done
acelaya opened this issue Mar 13, 2024 · 2 comments
Closed
10 tasks done

Comments

@acelaya
Copy link
Contributor

acelaya commented Mar 13, 2024

We are currently displaying an actionable button in the sidebar's top bar when there are pending updates. However, this is a bit too subtle and not everyone understands what is it for, ending up ignoring it.

image

We want to transition into a more intuitive notification that is displayed with an animation, and basically indicates the availability of pending updates.

notification-2024-03-13_15.16.51.mp4

Considerations:

  • Handle feature through a feature flag.
  • The notification should be accessible, announcing screen readers when it appears.

Documents:

TODO

@acelaya acelaya self-assigned this Mar 13, 2024
@acelaya acelaya changed the title Create a new toas-like notification that is displayed when there are pending updates Create a new toast-like notification that is displayed when there are pending updates Mar 13, 2024
@acelaya
Copy link
Contributor Author

acelaya commented Mar 20, 2024

Icon from design in SVG (copied from figma)

<svg width="16" height="16" viewBox="0 0 16 16" fill="red" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M8.70711 11.7071L8.6129 11.7903L8.5114 11.8596C8.12751 12.0884 7.62334 12.0375 7.29289 11.7071L3.29289 7.70711L3.2097 7.6129C2.90468 7.22061 2.93241 6.65338 3.29289 6.29289L3.3871 6.2097C3.77939 5.90468 4.34662 5.93241 4.70711 6.29289L7 8.585V1L7.00673 0.883379C7.06449 0.38604 7.48716 0 8 0C8.55229 0 9 0.447715 9 1V8.585L11.2929 6.29289L11.3871 6.2097C11.7794 5.90468 12.3466 5.93241 12.7071 6.29289C13.0976 6.68342 13.0976 7.31658 12.7071 7.70711L8.70711 11.7071ZM15.9933 9.88338C15.9355 9.38604 15.5128 9 15 9L14.8834 9.00673C14.386 9.06449 14 9.48716 14 10V14H2V10L1.99327 9.88338C1.93551 9.38604 1.51284 9 1 9C0.447715 9 0 9.44771 0 10V15L0.00672773 15.1166C0.0644928 15.614 0.487164 16 1 16H15L15.1166 15.9933C15.614 15.9355 16 15.5128 16 15V10L15.9933 9.88338Z" fill="black"/>
</svg>

@acelaya
Copy link
Contributor Author

acelaya commented Apr 16, 2024

I'm closing this as completed, but the feature is still disabled via FF. There's ongoing conversations around when to enable it.

There will be some potential follow-up tasks to improve some aspects around highlighting and scrolling into loaded annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant