Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-closable dialogs are still displaying the close button #1043

Closed
acelaya opened this issue May 22, 2023 · 1 comment
Closed

Non-closable dialogs are still displaying the close button #1043

acelaya opened this issue May 22, 2023 · 1 comment
Assignees
@acelaya
Labels
bug

Comments

@acelaya
Copy link
Contributor

acelaya commented May 22, 2023

After the introduction of TransitionComponents support in Dialogs, the logic to determine if the close button should be displayed or not was broken.
@acelaya acelaya added the bug label May 22, 2023
@acelaya acelaya self-assigned this May 22, 2023
@acelaya
Copy link
Contributor Author

acelaya commented May 22, 2023

Duplicates #1044

@acelaya acelaya closed this as completed May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acelaya acelaya

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acelaya