Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reusable toast messages component #1075

Closed
lyzadanger opened this issue Jun 1, 2023 · 2 comments · Fixed by #1272
Closed

Add reusable toast messages component #1075

lyzadanger opened this issue Jun 1, 2023 · 2 comments · Fixed by #1272
Assignees
Labels
component concerning a UI component that is part of the package API

Comments

@lyzadanger
Copy link
Contributor

We have an upcoming need for toast messages in a new application. The client application already has toast messages. Extract and add a toast message component to this package.

@lyzadanger lyzadanger added the component concerning a UI component that is part of the package API label Jun 1, 2023
@lyzadanger lyzadanger self-assigned this Jun 1, 2023
@lyzadanger
Copy link
Contributor Author

As of now, I'm not entirely convinced we need the full toast-message functionality for this application. Perhaps. But the new Callout component released in v6.4.0 might do the trick.

@acelaya
Copy link
Contributor

acelaya commented Jul 31, 2023

Since on first pass we are creating the component directly in via, I'll remove the "video annotations" label from this ticket.

Once hypothesis/via#1125 is merged, I will do further testing on how to use the component in client, and adapt where needed.

Once both projects can use this component, we can probably get back to this issue and move the component to frontend-shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component concerning a UI component that is part of the package API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants