Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SvgIcon component to SVGIcon #119

Closed
esanzgar opened this issue Jun 25, 2021 · 1 comment
Closed

Rename SvgIcon component to SVGIcon #119

esanzgar opened this issue Jun 25, 2021 · 1 comment
Labels
component concerning a UI component that is part of the package API package or API related to the build, structure or API of the frontend-shared package

Comments

@esanzgar
Copy link
Contributor

According to our naming standards, SvgIcon component should be renamed SVGIcon.

This will be a breaking change for consumers of our package.
@lyzadanger lyzadanger added component concerning a UI component that is part of the package API package or API related to the build, structure or API of the frontend-shared package labels Sep 10, 2021
@lyzadanger
Copy link
Contributor

We ended up creating an Icon component as of #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component concerning a UI component that is part of the package API package or API related to the build, structure or API of the frontend-shared package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lyzadanger @esanzgar