You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As you can see in this screen video of the new files-with-subfolders interface, the modal height jumps around as different file sets are loaded.
We've struggled with modal heights for some time, and have introduced some specific fixes in various parts of the LMS application. Lately, we introduced a new shared Modal component that can impose some height and overflow controls. That would work well here, but before it can, the Table component needs some adjustments to be able to behave correctly in this variant of Modal.
Once the shared Table component is available, use it within the shared Dialog component in these contexts to rectify Modal-height flailing.
One way I was able to achieve the desired behavior in prototyping some time ago was to use contain: size on the table content in browsers that support it. This tells the browser than the table should ignore its children when calculating its size and instead use an explicitly specified size as its preferred size, while still having the ability to shrink if needed. What I then did was set this explicit preferred size to be roughly N rows for some small value of N. Unfortunately Safari doesn't support CSS Containment, so we'll have to find another approach, or just have a fallback in place for Safari.
As you can see in this screen video of the new files-with-subfolders interface, the modal height jumps around as different file sets are loaded.
We've struggled with modal heights for some time, and have introduced some specific fixes in various parts of the LMS application. Lately, we introduced a new shared
Modal
component that can impose some height and overflow controls. That would work well here, but before it can, theTable
component needs some adjustments to be able to behave correctly in this variant ofModal
.Once the shared
Table
component is available, use it within the sharedDialog
component in these contexts to rectify Modal-height flailing.Depends on hypothesis/frontend-shared#157
Part of #2943
The text was updated successfully, but these errors were encountered: