Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discovery] Show all annotations in an EPUB book #1253

Closed
chrisshaw opened this issue Nov 19, 2021 · 4 comments
Closed

[Discovery] Show all annotations in an EPUB book #1253

chrisshaw opened this issue Nov 19, 2021 · 4 comments

Comments

@chrisshaw
Copy link

chrisshaw commented Nov 19, 2021

As a student, I want to view annotations outside of the current chapter, so I can view conversations that span multiple chapters, like personal notes and non-chapter assignments.

Teachers and students expect Hypothesis to work like it does in other tools. That means we show all the annotations for the "document," in this case the book. We currently don't have a way to pull from notes across multiple "pages" in a PDF. This is a problem when we run into PDFs that have multiple pages for a single chapter.

The output of this story is an internally demoable prototype.

Flow

  • When I open the assignment, I see annotations for the entire book
  • The annotations that are located on the content work as expected

Notes

Technical details

  • What will happen to existing VitalSource annotations?
    • (Because we'll be adding new metadata) If we want to preserve them, we'll need to migrate the old cards.
@chrisshaw chrisshaw changed the title [VitalSource] Show all annotations in a book in Notebook (as defined by VitalSource) [VitalSource] Show all annotations in a book (as defined by VitalSource) Nov 22, 2021
@chrisshaw chrisshaw changed the title [VitalSource] Show all annotations in a book (as defined by VitalSource) [Core][PDF] Show all annotations in a book (as defined by VitalSource) Dec 14, 2021
@chrisshaw chrisshaw changed the title [Core][PDF] Show all annotations in a book (as defined by VitalSource) [EPUB][PDF] Show all annotations in a book (as defined by VitalSource) Dec 14, 2021
@chrisshaw
Copy link
Author

chrisshaw commented Feb 4, 2022

  • How would we adapt the UI for loading so many annotations?
    • Now has draft issues
  • How do we incorporate logical location (and can we wait on that)?
    • Now has draft issues

Other notes

@robertknight
Copy link
Member

Inline notes at https://hyp.is/go?url=https%3A%2F%2Fgithub.com%2Fhypothesis%2Fproduct-backlog%2Fissues%2F1253&group=1y5rJZVR

As an aside, the experience if you follow this link and are not already a member of the group is really bad. It just gives you a "couldn't fetch group" message with no indication as to how to join the group (or whether it can be joined).

@chrisshaw chrisshaw changed the title [EPUB][PDF] Show all annotations in a book (as defined by VitalSource) [EPUB][PDF] Demo: Show all annotations in a book (as defined by VitalSource) Feb 8, 2022
@chrisshaw
Copy link
Author

Inline notes at https://hyp.is/go?url=https%3A%2F%2Fgithub.com%2Fhypothesis%2Fproduct-backlog%2Fissues%2F1253&group=1y5rJZVR

As an aside, the experience if you follow this link and are not already a member of the group is really bad. It just gives you a "couldn't fetch group" message with no indication as to how to join the group (or whether it can be joined).

Agreed @robertknight, I ran into this too. I've captured it as another UX tweak we should make some day.

@chrisshaw chrisshaw changed the title [EPUB][PDF] Demo: Show all annotations in a book (as defined by VitalSource) [Discovery] Show all annotations in an EPUB book (as defined by VitalSource) May 5, 2022
@chrisshaw chrisshaw changed the title [Discovery] Show all annotations in an EPUB book (as defined by VitalSource) [Discovery] Show all annotations in an EPUB book May 5, 2022
@robertknight
Copy link
Member

robertknight commented Jan 25, 2023

This has now been done, as part of this project: https://github.com/orgs/hypothesis/projects/96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants