-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Firefox Hypothesis extension #637
Comments
Is this still being worked on? I'm asking because it's been years now since the issue went limbo. Firefox support is the only barrier left for mass adoption but I'm not sure I should hold my breath on it anymore. |
Hi @ZiadJ - Still on the roadmap but we haven't been actively working on it as we've had other priorities for various reasons. You can build a Firefox extension from code in the browser-extension repository but there is probably work needed to adapt to the latest Firefox releases (WebExtensions has been undergoing quite a lot of changes) and on our side to actually get it into production. |
@ZiadJ we do have a bookmarklet that works with Firefox which you could use in the meantime - see Step 2 here: https://web.hypothes.is/start/ |
FWIW with Waterfox Classic 56.2.12 I can run the extension for Chromium-based browsers through Chrome Store Foxified and get this: – and authentication apparently succeeds but then the sidebar continues to show the prompt to log in. The not logged in (NLI) view does, at least, show annotations, for example: SuggestionThe badge should be disabled by default following installation of the extension. Rationale: privacy. |
Whilst it's nice to have the bookmarklet, there's the unavoidable frustration of bookmarklets of this type (not solely Hypothesis) not working with various sites. Note that the bookmarklet doesn't work on sites with restrictive CSP · Issue #209 · hypothesis/vision (2016, archived) So for example https://twitter.com/judell/status/1152257422125223936 again, in a different Waterfox Classic profile, after clicking the bookmarklet: – to the right, no sidebar. |
@grahamperrin that's very interesting. I also use Waterfox to run an orphan ftp add-on, did not know about Chrome Store Foxified, which is evidently discontinued but also runs as an orphan in Waterfox. You got farther than I did! If I could reproduce what you've done to get the Hypothesis sidebar to open in Waterfox by way of Chrome Store Foxified, I might be able to suss out your auth issue. But I can't. Are you able to reproduce the situation in which the sidebar did load, and you were able to (albeit not stickily) authenticate? |
Yes, with home-built Waterfox Classic 56.2.12 and a new profile on FreeBSD-CURRENT. Join me in IRC if you like (directions: https://web.hypothes.is/help/how-can-i-get-access-to-the-code-or-talk-to-hypothesis-developers/#hkb), I'm connected via Riot/Matrix. I'll be snoozing whilst connected so just fire away and I'll pick up reasonably soon. Thanks |
FYSA Firefox 69 will fix bookmarklets on sites with restrictive CSP: |
Leaving a comment just to watch this conversation. Hope it stays open until the extension is released. |
An extension to get past the CSP problems would be much welcome. |
FYI, on Android you may switch to Firefox-nightly("fenix) which permits the installation of ANY add-on, when following the official procedure, including the the "unofficial bookmarklet" from Hernawan which i tested it and work flawlessly even in restrictive-CSP sites like GitHub. I tested also the "unofficial-hypothesis" add-on but it didn't work due to diegodlh/unofficial-hypothesis-extension#4. |
Hello. This request exists since 2018 (or perhaps longer). Did any development happen? |
We still have a Firefox extension "in development" (as in, you can check out this repository and build one) but we've never gotten to the point of actually shipping it as something you can download from our website or addons.mozilla.org for various reasons. I'm afraid I can't make any promises about when that will happen, except to say that it is something we would still like to do. |
Got it. We still miss it, though. So instead of asking "when", may we ask you "who" (who could do/is doing this), so that we can positively encourage him/her? :) |
It still WIP? |
Shipping the FF add-on supports H's goals for global usage.
From a short conversation with Rob, the primary reason this hasn't been shipped is that the manual review process was unreasonably long. After some basic research, this concern has since been alleviated (barring a Recommended badge).
The text was updated successfully, but these errors were encountered: