Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations are lost when PDF fingerprint changes #192

Open
mattdricker opened this issue Apr 7, 2021 · 1 comment
Open

Annotations are lost when PDF fingerprint changes #192

mattdricker opened this issue Apr 7, 2021 · 1 comment

Comments

@mattdricker
Copy link
Contributor

[I fully recognize that this title of this issue is actually describing the way Hypothesis is meant to work with PDFs, but there are circumstances where this behavior is surprising and/or problematic to users. This issue comes out of a discussion between myeslf, @mkdir-washington-edu , and @robertknight , and is an attempt to describe these concerns.]

Occasionally a user will need to edit or alter a PDF in a way that changes the fingerprint:

  • User discovers garbled or unusable text layer and needs to run PDF through OCR again
  • Original PDF is lost or deleted from host, and new PDF needs to be found and/or re-uploaded
  • Original PDF does not display properly in certain platforms/environments, necessitating creation of a new PDF

All of these scenarios result in the new PDF containing a different fingerprint than the original, thus losing any annotations previous associated with that document.

In these cases, if there was a method to maintain document equivalency, or create an association between the previous version and the new, previous annotations could persist.

@klemay
Copy link
Contributor

klemay commented Apr 7, 2021

it's good to know when expected behavior is confusing or interferes with user workflows - thank you for filing this. I have added it to the bug & product backlog for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants