Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPIKE: Remove "Open" button from PDF.js #202

Open
mattdricker opened this issue May 13, 2021 · 0 comments
Open

SPIKE: Remove "Open" button from PDF.js #202

mattdricker opened this issue May 13, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@mattdricker
Copy link
Contributor

PDF.js includes an icon in the toolbar for opening a new PDF in the viewer.

Using this feature while Hypothesis is active results in a confusing experience for the user:

  • The new PDF is loaded in the viewer, but annotations from the previously shown PDF still display in the sidebar
  • User can annotate in the new document, with new annotation added in the sidebar with the old

This is especially unwanted in the LMS app, where a instructor has assigned a specific document and there should not be any opportunity for a student to open a different document in the same viewer.

Screen Shot 2021-05-13 at 3 45 11 PM
@mkdir-washington-edu mkdir-washington-edu added the bug Something isn't working label May 25, 2021
@mkdir-washington-edu mkdir-washington-edu changed the title Remove "Open" button from PDF.js SPIKE: Remove "Open" button from PDF.js Jun 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkdir-washington-edu @mattdricker