Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: Fix previously-saved "PDF.js" doc titles so when PDFs are re-used in the LMS app we capture a better file name #206

Open
mkdir-washington-edu opened this issue May 25, 2021 · 1 comment

Comments

@mkdir-washington-edu
Copy link
Contributor

Describe the bug
Title isn't great. Not trying to propose a solution. Slack convo here: https://hypothes-is.slack.com/archives/DLX8FBWBB/p1621610716002300

We're going to be collecting better titles than "PDF.js" in the future on the occasions where there is no "title" PDF metadata: hypothesis/client#3372.

This will not fix documents for which we've already stored "PDF.js" as the file title. As an example, a professor is probably going to re-use the same PDF every semester, so they'll continue to get "PDF.js" as the doc title going forward. We'll want to find a way to fix already saved document titles.

Expected behavior
Using a PDF with no "title" metadata, even one you've used before, results in a better title than "PDF.js".

Additional context
These titles are especially important in Notebook in the LMS app where it can be difficult to tell which PDF.js assignment an annotation is associated with.

@mkdir-washington-edu mkdir-washington-edu changed the title Fix previously-saved "PDF.js" doc titles so when PDFs are re-used in the LMS app we capture a better file name SPIKE: Fix previously-saved "PDF.js" doc titles so when PDFs are re-used in the LMS app we capture a better file name Jun 1, 2021
@mkdir-washington-edu
Copy link
Contributor Author

List of documents where doc title = "PDF.js viewer" - GDrive link

Some example documents:

Next steps:
Support: Test to see if new annotation updates the title (doc titles visible in notebook)
Then delete one doc title and see if it fixes
Then TBD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant