-
-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stacked group tabs #5886
Stacked group tabs #5886
Conversation
Oops, missed an array index. Try now please |
Yep, fine now |
not sure if intentional but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't build hyprland atm to test, but rest lgtm
I'm not sure it's something to address in a PR like this, but I have to ask. Does anyone actually use this drag+drop reordering onto the group bar functionality? And if you do how the hell? Every window drag converts to a floating window and blocks a huge part of the group bar. Your drops onto the group bar are effectively blind due to the window covering it. Sway/i3 actually render indicators on the bar to tell you where the drop will go, but they also don't render the whole window during drag (actually they don't immediately pop dragged windows out of the layout and float them). Mouse users, tell me your secret |
I use it, most of the times with 3 or less windows. Window dragging opacity and relative/absolute size should prolly be configured (no just for group dragging). |
Come to find out the hidden tech of just setting all my floating windows fully transparent made it much easier to sort out dnd.... |
rest lgtm |
if this is ready it's probably a good idea to ping vaxry before it needs rebasing |
whomst'd've said my name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks more or less ok I guess just wiki mr
* Stacked group tabs * Fix index when creating groupbar title textures * Changes for stacked dnd * formatting * Don't remove internal horizontal padding when calculating stacked bar width
Describe your PR, what does it fix/add?
Render the groupbar tabs vertically, like sway/i3's "stacked" windows.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
Can be merged. Maybe the only thing missing is a way to toggle a group between 'tabbed' and 'stacked' dynamically? I have a few other dispatcher/group related things I may do so I'll bundle it up with those sometime in the future