Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo prints out values for variables passed in the build #1

Open
sujen1412 opened this issue Mar 1, 2018 · 0 comments
Open

Echo prints out values for variables passed in the build #1

sujen1412 opened this issue Mar 1, 2018 · 0 comments

Comments

@sujen1412
Copy link

https://github.com/hysds/container-builder/blob/master/build-container.bash#L101-L102

This line logs the values of any variable passed in the ci during the build which could include secret keys.
We should not echo it or restrict it to echoing variable names rather than the values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant