Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new parser setup breaks alias setup with Yireo Example Checkout #181

Closed
DanielRuf opened this issue Sep 16, 2021 · 2 comments
Closed

new parser setup breaks alias setup with Yireo Example Checkout #181

DanielRuf opened this issue Sep 16, 2021 · 2 comments

Comments

@DanielRuf
Copy link

It seems the new parser setup breaks projects with alias configurations.

Here the new parser was added:
6320c49#diff-c9fbe45db4b426bcbfa0b209c78e49d625b109e2c473263f232fd756dde5fe77R74

And here it was loaded in the eslint config:
777548b

We had to temporarily add 'import/no-unresolved': 0, to the eslint config to make eslint happy and get everything to build.

Related:
babel/babel#11975 (happens when setting the alias via eslintrc config for the import plugin)

Also scoped (@hyva/...) aliases won't work anymore due to this: https://github.com/import-js/eslint-plugin-import/blob/9bac44e629105572ca78a532c968df202e5a18b8/src/core/importType.js#L46

import-js/eslint-plugin-import#496
tleunen/eslint-import-resolver-babel-module#77 (related to @ aliases)
aze3ma/react-app-rewire-aliases#1 ( issue starts at the react-app-rewired level)

https://github.com/yireo-training/Yireo_ExampleHyvaCheckout/blob/master/reactapp/config-overrides.js#L53 (the current setup)

@rajeev-k-tomy
Copy link
Collaborator

rajeev-k-tomy commented Sep 22, 2021

@DanielRuf I checked out Yireo_ExampleHyvaCheckout module and fixed the incompatibility with the 1.0.0-rc2. You can find the PR here: yireo-training/Yireo_ExampleHyvaCheckout#2

@rajeev-k-tomy
Copy link
Collaborator

@DanielRuf We have a new space for this: https://github.com/hyva-themes/magento2-checkout-example

So we will be focusing on this repo from now onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants