Problem in the handler function

[peel70]

Hi, I think there is a problem in the handler function.
After the first time the scroll go to the end and is fired the event to load data, the handler function does not update the rows and the lastChoice variable so for every scroll is fired the event to load data.
Maybe I don't understand very well to use the extension.
Please let me know.
Best regards
Enrico

[peel70]

I temporary put this two lines in the handler function, I know this is not optimized but it work

var handler = function() {
var rows = elem.querySelectorAll('.ui-select-choices-row');
var lastChoice = angular.element(rows[rows.length - 1]);

.........

every time the handler function is called (for every scroll event) I recalculate the lastChoise

[peel70]

Hi, I found another solution but I need your opinion.
I put a watcher on the $select.items array and only when the select is opened I assign a local boolean variable that tell to handler function to recalculate the last element.
I put this watcher in the link function of the directive

var itemsWatcher = scope.$watch('$select.items', function(newItems, oldItems) {
if(scope.$select.open == true) {
needLastChoiceUpdate = true;
}
}, true);

in the handler function I put this code:

var handler = function() {
if(needLastChoiceUpdate == true) {
var rows = elem.querySelectorAll('.ui-select-choices-row');
var newLastChoice = angular.element(rows[rows.length - 1]);
if( newLastChoice != lastChoice ) needLastChoiceUpdate = false;
lastChoice = newLastChoice;
}
//... rest of the function

because the function that will download the new items is async I make another check if the newLastChoice is different from the previous so at the next scroll event I decided to evaluate the last choice again.

The itemsWatcher has to be destroyed in the

scope.$on('$destroy', function() {
// .....
itemsWatcher();
});

Please let me know
Best regards
Enrico

[zukilover]

is this still being maintained?

[hyzhak]

@zukilover sure