Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(adapters): implement embed #210

Merged
merged 12 commits into from
Dec 9, 2024
Merged

feat(adapters): implement embed #210

merged 12 commits into from
Dec 9, 2024

Conversation

vabarbosa
Copy link
Contributor

@vabarbosa vabarbosa commented Dec 2, 2024 •
edited
Loading

Which issue(s) does this pull-request address?

Closes: #176

Description

this PR adds the embed method to the BaseLLM and adds the implementation into the adapters extending BaseLLM. the implementation of the various embed methods are taken from the API implementation of these embeds. some adapters do not yet have the embed methods fully implemented and as such will throw a Method not implemented exception.

Checklist

  • I have read the contributor guide
  • Linting passes: yarn lint or yarn lint:fix
  • Formatting is applied: yarn format or yarn format:fix
  • Unit tests pass: yarn test:unit
  • E2E tests pass: yarn test:e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

@vabarbosa vabarbosa requested a review from a team as a code owner December 2, 2024 19:52
@vabarbosa
feat(adapters): implement embed
7c96136 
Signed-off-by: va <va@us.ibm.com>
Signed-off-by: //va <va@us.ibm.com>
Tomas2D
Tomas2D reviewed Dec 2, 2024
View reviewed changes
@vabarbosa
feat(adapters): embed output interface
0262e1b 
Signed-off-by: //va <va@us.ibm.com>
Tomas2D
Tomas2D requested changes Dec 4, 2024
View reviewed changes
vabarbosa and others added 2 commits December 6, 2024 09:13
@vabarbosa
feat(adapters): review feedback
9b0256d 
Signed-off-by: //va <va@us.ibm.com>
@michael-desmond
fix(llms): remove limit from bam embeddings
063a00a 
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
@vabarbosa vabarbosa requested a review from Tomas2D December 6, 2024 17:50
@michael-desmond
Merge branch 'main' into va-embed
3caf8fc
@michael-desmond
fix: formatting issue
adc5b80 
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Tomas2D
Tomas2D reviewed Dec 7, 2024
View reviewed changes
Copy link
Contributor

@Tomas2D Tomas2D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see implementations for concrete LLM providers.

Tomas2D
Tomas2D reviewed Dec 9, 2024
View reviewed changes
@vabarbosa
feat(adapters): review feedback
bbcca1e 
Signed-off-by: //va <va@us.ibm.com>
Tomas2D
Tomas2D reviewed Dec 9, 2024
View reviewed changes
@vabarbosa
feat(adapters): update naming
21031e5 
Signed-off-by: //va <va@us.ibm.com>
@vabarbosa
feat(adapters): update naming
2843004 
Signed-off-by: //va <va@us.ibm.com>
@Tomas2D Tomas2D merged commit 84a3bf4 into main Dec 9, 2024
4 checks passed
@Tomas2D Tomas2D deleted the va-embed branch December 9, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-desmond michael-desmond michael-desmond left review comments

@Tomas2D Tomas2D Tomas2D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LLM - add embedding support
3 participants
@vabarbosa @michael-desmond @Tomas2D