-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agents): granite agent fixes, update granite docs and examples #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor bits to clean up and think about in the README. I also wonder whether we need some explanation around why the tooling is configured the way it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like all the original review points have been addressed. We need to get this one merged ASAP so that we can use the resulting repo in the creation of some demo materials. @Tomas2D would you be able to go ahead and do the merge as it stands now?
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: Graham White <gwhite@uk.ibm.com>
Signed-off-by: Graham White <gwhite@uk.ibm.com>
a869350
to
008292d
Compare
Signed-off-by: Graham White <gwhite@uk.ibm.com>
Signed-off-by: Graham White <gwhite@uk.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work guys! 🚀
Which issue(s) does this pull-request address?
examples/granite
)/docs
to to aREADME.md
inside ofexamples/granite
so we can link directly to the README and the code examples (cookbook)Checklist
yarn lint
oryarn lint:fix
yarn format
oryarn format:fix
yarn test:unit
yarn test:e2e