Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): verify that the end date is later than the start date #244

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

michael-desmond
Copy link
Contributor

Which issue(s) does this pull-request address?

If the llm uses the openMeteo tool with a startDate in the future, but does not specify an endDate then the endDate is set to now which is prior to the start date. This causes the the service to throw an error.

Description

Check of the end data is prior to the start date, if so reset the end date.

Checklist

  • I have read the contributor guide
  • Linting passes: yarn lint or yarn lint:fix
  • Formatting is applied: yarn format or yarn format:fix
  • Unit tests pass: yarn test:unit
  • E2E tests pass: yarn test:e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
@michael-desmond michael-desmond requested a review from a team as a code owner December 11, 2024 02:45
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
Signed-off-by: MICHAEL DESMOND <mdesmond@us.ibm.com>
@Tomas2D Tomas2D enabled auto-merge (squash) December 13, 2024 07:53
@Tomas2D Tomas2D disabled auto-merge December 13, 2024 07:53
@Tomas2D Tomas2D merged commit eee4cb5 into main Dec 13, 2024
4 checks passed
@Tomas2D Tomas2D deleted the openmeteo_enddate branch December 13, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants