You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current factory method for agent workflows in Python lacks clarity in naming and structure. In the current implementation, agents are created and configured using AgentFactoryInput, which is passed to the add_agent method of the AgentWorkflow. A few concerns with this:
The class AgentFactoryInput is misleading because it suggests it is responsible for creating agents when it only holds the necessary data to configure an agent
The add_agent method both creates and adds agents to the workflow which conflates two different responsibilities
The current implementation is a 1:1 match with TypeScript - we need to make it more Pythonic
Possible solutions
Rename AgentFactoryInput to AgentConfig ?
Separate add_agent method out to 2 methods: add + create
The text was updated successfully, but these errors were encountered:
Description
The current factory method for agent workflows in Python lacks clarity in naming and structure. In the current implementation, agents are created and configured using
AgentFactoryInput
, which is passed to theadd_agent
method of theAgentWorkflow
. A few concerns with this:The class
AgentFactoryInput
is misleading because it suggests it is responsible for creating agents when it only holds the necessary data to configure an agentThe
add_agent
method both creates and adds agents to the workflow which conflates two different responsibilitiesThe current implementation is a 1:1 match with TypeScript - we need to make it more Pythonic
Possible solutions
AgentFactoryInput
toAgentConfig
?add_agent
method out to 2 methods: add + createThe text was updated successfully, but these errors were encountered: