Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for react 17 - context api update #405

Closed
jamuhl opened this issue Mar 16, 2018 · 2 comments
Closed

prepare for react 17 - context api update #405

jamuhl opened this issue Mar 16, 2018 · 2 comments

Comments

@jamuhl
Copy link
Member

jamuhl commented Mar 16, 2018

guess we need to polyfill it to stay backwards compatible with older versions and preact

possible polyfill: https://github.com/jamiebuilds/create-react-context

or completely remove the context stuff in favour of setting the build in i18nInstance using the reactI18nextModule https://react.i18next.com/components/i18next-instance.html#i18next-instance

or the setDefaults in our own global state: https://github.com/i18next/react-i18next/blob/master/src/context.js

@langovoi
Copy link
Contributor

langovoi commented Apr 2, 2018

@jamuhl
Copy link
Member Author

jamuhl commented Sep 30, 2018

using https://github.com/jamiebuilds/create-react-context this was done in react-i18next@8.0.0

@jamuhl jamuhl closed this as completed Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants