Infiinite loop caused

[developdeez]

I keep getting infinite loop errors when using the HOC 'withNamespaces'
I put it on a child component of a page that is also translated.

[jamuhl]

please provide a https://codesandbox.io/s/l4qrory2nl to reproduce 99.9% sure not related to this module but to either your code or misconfiguration

[qventura]

If it can help, I had a similar issue when I set a fallbackLng that has no corresponding resources

[jamuhl]

please start adding changes related to the v9 version to the v9.x.x branch (master will be now for the upcoming v10 hooks)

--> https://github.com/i18next/react-i18next/tree/v9.x.x

[cthurston]

I'm getting an infinite loop when the backend fails to load. Probably related, but I'm using alpha v10.

[jamuhl]

@cthurston with current published react-i18next@10.0.0-alpha.1? or an old v9

think i fixed that...376fe57#diff-cfd6b2fa22409acc10b6dab14d52cdb1R51

[cthurston]

I'm using the current published react-i18next@10.0.0-alpha.1. For some reason it is sending an empty languages array. This causes ready to always be false. Near line 45 in useTranslation. If I put a guard in the every callback, it seems not to crash.

var ready = i18n.isInitialized && namespaces.every(function (n) {
    if(!i18n.languages || !i18n.languages.length) return true

Until I added the languagedetector back in. Then it hit an infinite loop again.

For now I'm just returning true from the callback, seems to work.

[jamuhl]

can you paste your i18next options? wondering how i18n.languages can be empty after init

[cthurston]

{
  fallbackLng: 'en',
  ns: ['default'],
  defaultNS: 'default',
  fallbackNS: 'default',
  nsSeparator: '::',
  keySeparator: '::',
  debug: true,
  interpolation: {
    escapeValue: false, // not needed for react!!
  },
  backend: {
    loadPath: `${REACT_APP_API_SERVER}/locales/{{lng}}/{{ns}}/translation.json`,
    crossDomain: true,
  },
}

[jamuhl]

strange if isInitialized is set on i18next languages should be at least ['en'] - really don't get how i18next.languages can be undefined

[jamuhl]

  const ready =
    i18n.isInitialized &&
    namespaces.every(n => {
      const ret =
        i18n.hasResourceBundle(i18n.languages[0], n) ||

So guess it's an empty array...i'm confused

[cthurston]

var ready = i18n.isInitialized && namespaces.every(function (n) {
    console.log('Ready?', n, i18n.languages)

Without language detector:

But even with language detector and languages ['en', 'en-US'] it still hits an infinite loop if the backend doesn't respond.

[jamuhl]

ah...if not using a detector you need to set lng: 'en|de|fr' lng to whatever you want it to be.

Wonder if we should force taking the fallbackLng as lng if not set by user -> seems not to be clear it has to be set when not using a detector?!?

ok if backend fails completely it will never get ready - will make a check for everything failing to load

[jamuhl]

@cthurston might be fixed in react-i18next@10.0.0-alpha.2

[jamuhl]

closing for now...feel free to provide a sample to reproduce.