Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: explicit React imports #1525

Merged
merged 1 commit into from
Jun 26, 2022
Merged

style: explicit React imports #1525

merged 1 commit into from
Jun 26, 2022

Conversation

jy95
Copy link
Contributor

@jy95 jy95 commented Jun 26, 2022 •
edited
Loading

For easier tree shaking (webpack, rollup, ...), actual used imports for React could be explicit

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

image

@jy95
style: explicit React imports
6bd768f 
For easier tree shaking
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.841% when pulling 6bd768f on jy95:master into 2eb6349 on i18next:master.

@adrai adrai merged commit 15afe75 into i18next:master Jun 26, 2022
@adrai
Copy link
Member

adrai commented Jun 26, 2022

thank you
included in v11.17.3

@adrai adrai mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jy95 @coveralls @adrai