Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing MSP Option for the Receiver wizard #2162

Open
b14ckyy opened this issue Aug 8, 2024 · 4 comments
Open

Missing MSP Option for the Receiver wizard #2162

b14ckyy opened this issue Aug 8, 2024 · 4 comments

Comments

@b14ckyy
Copy link
Collaborator

b14ckyy commented Aug 8, 2024

When i set up a new craft and using the new Setup Wizard, I have no option to select MSP as the main RC source.
This would be needed for MSP-RC from mLRS (And maybe, just maybe in the future for ELRS as well).
image

@mmosca
Copy link
Collaborator

mmosca commented Aug 19, 2024

That is because this assumes serial rx. And MSP is not an option for serial rx.

# get receiver_type 
receiver_type = SERIAL
Allowed values: NONE, SERIAL, MSP, SIM (SITL)


# get serialrx_provider 
serialrx_provider = CRSF
Allowed values: SPEK1024, SPEK2048, SBUS, SUMD, IBUS, JETIEXBUS, CRSF, FPORT, SBUS_FAST, FPORT2, SRXL2, GHST, MAVLINK, FBUS, SBUS2

@b14ckyy
Copy link
Collaborator Author

b14ckyy commented Aug 20, 2024

You think it makes sense to add the Receiver Type to the Wizard? Not sure how many people will set it to MSP or SIM in the future. Its also confusing that MAVLINK is a serial Rx provider and not a receiver type here. as it also needs to be SerialRx turned off in the Ports tab.

@mmosca
Copy link
Collaborator

mmosca commented Aug 20, 2024 via email

@b14ckyy
Copy link
Collaborator Author

b14ckyy commented Aug 20, 2024

I am fine with one or the other.

Either add receiver_type to the Wizard or put MSP as a Serialrx_provider.

Maybe moving MAVLINK to receiver_type though might make more sense as all the serialrx_provider options need the Serial Rx switch in Ports tba to be on. MSP and Mavlink do not. This might be a more streamlined option.

additionally there is a chance that even ELRS might get MSP-RC support at some point as I know from 2 major ELRS devs that they like the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants