Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing used timer def in OMNIBUS target #3096

Closed
flybabo opened this issue Apr 22, 2018 · 3 comments
Closed

Missing used timer def in OMNIBUS target #3096

flybabo opened this issue Apr 22, 2018 · 3 comments
Labels
Milestone

Comments

@flybabo
Copy link

flybabo commented Apr 22, 2018

While reviewing the code, I found out that TIM_N(8) is missing at USED_TIMERS defined in OMNIBUS/target.h.
Apparently, TIM8 is used in timerHardware[] @target.c.

@flybabo
Copy link
Author

flybabo commented Apr 22, 2018

I also found out that I2C3_SDA pin is incorrectly defined at drivers/bus_i2c_hal.c.
It must be PC9 not PB4.

@digitalentity
Copy link
Member

@flybabo good catch. Can you submit a PR to fix it?

@fiam
Copy link
Member

fiam commented Jun 7, 2018

This is no longer relevant. Since #3120, the targets don't need to list the used timers.

@fiam fiam closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants