Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3250 breaks Blackbox GPS altitude #3500

Closed
stronnag opened this issue Jul 2, 2018 · 1 comment
Closed

#3250 breaks Blackbox GPS altitude #3500

stronnag opened this issue Jul 2, 2018 · 1 comment
Assignees
Labels

Comments

@stronnag
Copy link
Collaborator

stronnag commented Jul 2, 2018

#3250 naively changed the recording of altitude such that it could be negative. While we need to be able to record -ve altitudes, this is obviously NOT the correct solution, as it causes the recorded altitude to oscillate between +ve and -ve values, as the image below shows.

This affect has been observed on multiple vehicles, so its not just a stupid GPS. Code needs to be updated to use blackboxWriteSignedVB also.

Fix under test.

image

@stronnag stronnag added the BUG label Jul 2, 2018
@stronnag stronnag self-assigned this Jul 2, 2018
@stronnag stronnag changed the title #3250 breaks Blackbox altitude #3250 breaks Blackbox GPS altitude Jul 2, 2018
@stronnag
Copy link
Collaborator Author

stronnag commented Jul 2, 2018

Fixed by #3501

@stronnag stronnag closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant