Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Hide Completed" mode with weekly/monthly measurable habits #2070

Open
miljenko20 opened this issue Nov 21, 2024 · 3 comments
Open

"Hide Completed" mode with weekly/monthly measurable habits #2070

miljenko20 opened this issue Nov 21, 2024 · 3 comments

Comments

@miljenko20
Copy link

Description

There is an issue with the "Hide Completed" mode when using measurable habits with weekly and monthly goals. Even when the cumulative weekly/monthly target is met or exceeded, the habit does not disappear from the list in "Hide Completed" mode. Instead, it seems to rely on whether a single day’s total meets or exceeds the entire weekly/monthly target, which is not expected behavior.
For example: If my weekly goal is 120 minutes of piano practice, the habit does not disappear even after accumulating more than 120 minutes over multiple days. It only disappears if I log 120 minutes or more on a single day.
This issue appears specific to weekly and monthly measurable habits and does not occur with daily measurable habits.

Steps to reproduce

  1. Create a measurable habit with a weekly goal (e.g., 120 minutes).
  2. Log entries over several days to cumulatively reach or exceed the weekly goal, but do not log more than the goal value (120 minutes) on any single day.
  3. Enable "Hide Completed" mode.
  4. Observe that the habit remains visible, even though the cumulative weekly goal has been achieved.

System information

Phone: Samsung Galaxy A32 4G
Phone Operating System: Android 13
App version: 2.2.1

Screenshots

I have attached screenshots to help illustrate the issue. Please note that the app is in Croatian, but I believe the visuals should be clear enough to understand the problem. Let me know if you need any additional details or further clarification.

WhatsApp Image 2024-11-21 at 22 58 26
WhatsApp Image 2024-11-21 at 22 58 26 (1)

Finally, I want to say how much I enjoy using the app. It is truly a fantastic tool—simple, intuitive, and highly customizable. I especially appreciate features like the ability to track progress visually and assign colors to habits. Thank you for your hard work and dedication to making this app so great!

Miljenko

@Discostu36
Copy link

This also occured to me. It would be great if the app supported both types of goals.

@GeorgeD88
Copy link

I decided to check out the repo finally because it seems like there are issues with tracking measurable habits over periods larger than 1 day. I found this older issue (turned into a discussion) and it seems to end in a reply from the repo owner (August 2022) expressing that there is no existing feature to handle marking numerical habits that are not daily, so it was a matter of adding that feature.

I'm actually very interested in this feature and would like to start contributing to open source, so if there's still some discussion about this feature, I'd love to be in the loop.

@GeorgeD88
Copy link

GeorgeD88 commented Jan 21, 2025

To add to the issue, although it was said to be a lack of feature, then why should a single day be marked/colored in if the non-daily quota is meant all within that one day? Maybe because although the app doesn't handle marking over periods larger than a day, if the entire non-daily quota was completed within 1 day, you're sure that you can mark that day.

Additionally though, I noticed random inconsistencies. (I went far back in history many weeks to make sure I was testing on a perfectly empty week) I have a habit that is 20 units per week, I went to an empty week and when I put a number less than 2, it stayed gray, but then 3 or more lit up, but the habit was nowhere near completed. Before this though, it wasn't triggering with much higher numbers, and even sometimes huge numbers in a single day over the quota weren't triggering, but today when I flipped to landscape, suddenly all the numbers were marked and even after flipping back, now any number of 3 or larger is marked. Also setting to 0 seems to still show the number as grayed out, rather than going back to completely untouched, which can be seen more easily when looking at the calendar view within a habit's page. It just seems like a lot of inconsistent behavior, I'm not sure how it's handled in the code. I'd love to jump in and help! I'll try to join the developer chat room tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants