Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree & Property widgets: Clean up internal APIs exposed through barrel file #811

Closed
grigasp opened this issue Apr 11, 2024 · 0 comments · Fixed by #885
Closed

Tree & Property widgets: Clean up internal APIs exposed through barrel file #811

grigasp opened this issue Apr 11, 2024 · 0 comments · Fixed by #885
Assignees
@jasdom
Labels
property widget Property grid widget and its components related issues tree widget Tree widget or its components related issues

Comments

@grigasp
Copy link
Member

grigasp commented Apr 11, 2024 •
edited
Loading

  • Do not export top-level @internal APIs through the barrel.
  • Use internal symbols approach for @internal members of public APIs.

As part of the change, also add a check-internal script to the pipeline (see here)
@grigasp grigasp added tree widget Tree widget or its components related issues property widget Property grid widget and its components related issues labels Apr 11, 2024
@jasdom jasdom mentioned this issue Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasdom jasdom

Labels
property widget Property grid widget and its components related issues tree widget Tree widget or its components related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tree and Property Widget: Cleanup internal APIs iTwin/viewer-components-react
2 participants
@jasdom @grigasp