Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a fullstack web-component using Lit for search.quarkus.io #96

Closed
2 tasks
ia3andy opened this issue Jan 8, 2024 · 1 comment
Closed
2 tasks

Comments

@ia3andy
Copy link
Owner

ia3andy commented Jan 8, 2024

I was pinged on a PR to enhance the search experience on quarkus.io. This was using Vue and I thought it would not have been easy to maintain on the long term.

This is why I suggested using the web-bundler and make it a Full-stack Web Component instead. This would be a good show-case for this use-case and would make this tool easier to maintain.. Win Win.

It took quite some time to implement as there are big constraints (fallbacks) due to infrastructure restriction in the community.

The web-component is implemented quarkusio/search.quarkus.io#58

Missing pieces to make it available in production:

  • add local search fallback
  • quarkus.io integration
@yrodiere
Copy link

yrodiere commented Jan 8, 2024

Thanks for staying on top of this.

A couple things to add:

  1. Add copyright mentions for the various assets copied to the search.quarkus.io repository.
    See qs web-components quarkusio/search.quarkus.io#58 (comment) :

    For the icons copyright, I've used the one from quarkusio so we should mimic what they are doing?

  2. Search should only get triggered when a minimum number of chars is entered OR a category is selected ; it's already implemented in the existing Vue application, see the request here and the code here and there.
  3. The abort logic needs some work, see qs web-components quarkusio/search.quarkus.io#58 (comment)
    and how it can be implemented here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants