Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when loaded in a hidden iframe on Firefox #73

Closed
skoda opened this issue Sep 9, 2016 · 2 comments
Closed

Exception when loaded in a hidden iframe on Firefox #73

skoda opened this issue Sep 9, 2016 · 2 comments

Comments

@skoda
Copy link

skoda commented Sep 9, 2016

As a result of this Firefox issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=548397

this line in emoji.js:
var st = window.getComputedStyle(document.body);

causes an exception on the next line if the code is executed within a hidden iframe.

My site only works with css support anyways, so I can patch it for myself easily enough, but I'm not sure what a good fix is in general.

@skoda
Copy link
Author

skoda commented Sep 9, 2016

Given that the issue is in Firefox (where CSS has basically always been available) you could probably just assume supports_css = true when st === null?

@iamcal iamcal closed this as completed in 9ae15b4 Sep 12, 2016
@iamcal
Copy link
Owner

iamcal commented Sep 12, 2016

good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants