Fix/invalid default compiler outputs #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reordered the if branches to have `solc_binary` given a value prior to calling `_get_combined_json_outputs`
iamdefinitelyahuman
approved these changes
Oct 12, 2021
iamdefinitelyahuman
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Parse the appropriate compiler version when determining output options.
Just seeing now there is also another PR that does this exact same thing ... but i have tests :)
Related: #126
How I did it
Just added an additional argument to specify which compiler to use when parsing options
How to verify it
There is a test. The solc 0.8.x series introduced a
function-debugoutput option, which was not available in previous compiler versions. This also happened to be the reason why using previous compiler versions, with a 0.8.x one installed raised errors.Checklist