Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using yarn plug'n'play: prop-types missing from dependencies #139

Closed
dgreuel opened this issue Jun 28, 2019 · 2 comments
Closed

Error when using yarn plug'n'play: prop-types missing from dependencies #139

dgreuel opened this issue Jun 28, 2019 · 2 comments

Comments

@dgreuel
Copy link

dgreuel commented Jun 28, 2019

Package "notistack@0.8.7" (via "/Users/dan/Library/Caches/Yarn/v4/npm-notistack-0.8.7-02776a28232f27b0aae669572170bacac1a88b70/node_modules/notistack/build/SnackbarItem/SnackbarItem.js") is trying to require the package "prop-types" (via "prop-types") without it being listed in its dependencies (react, react-dom, @material-ui/core, classnames, hoist-non-react-statics, react-is, notistack)
@iamhosseindhv
Copy link
Owner

Thanks for pointing this out. fix has been published as version v0.8.8

@jhrinoa
Copy link
Contributor

jhrinoa commented Jun 29, 2019

Oh. sorry and thanks for fixing this. I should have tested thoroughly especially when dealing with package.json. Lesson learned. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dgreuel @jhrinoa @iamhosseindhv