Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weekOfYear 'week' method doesn't seems to handle week number 53 for 'nl' locale #1030

Closed
gavinlight opened this issue Sep 1, 2020 · 2 comments
Closed

weekOfYear 'week' method doesn't seems to handle week number 53 for 'nl' locale #1030

gavinlight opened this issue Sep 1, 2020 · 2 comments

Comments

@gavinlight
Copy link

Describe the bug
Similar to the issue mentioned in #956, with a dutch locale (nl), the week number on the end of the year is incorrect.

Expected behavior
When selecting the 'nl' locale and trying to return the weeknumber via days('2020-12-31').week(), the number returned is 1, while dutch calenders are supposed to return 53. See https://www.kalender-365.nl/kalender-2020.html

Information

  • Day.js Version: [v1.8.34[
  • OS: [MacOS]
  • Browser [Chrome 84]
  • Time zone: [CEST]
@iamkun
Copy link
Owner

iamkun commented Sep 1, 2020

Thanks, Update Dutch (nl) locale to set correct yearStart config. 1533a2c

@iamkun
Copy link
Owner

iamkun commented Oct 27, 2020

I'll close this issue since it's been a while since it's been opened. Feel free to reopen if you have updates on this

@iamkun iamkun closed this as completed Oct 27, 2020
@chrfalch chrfalch mentioned this issue Apr 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavinlight @iamkun