Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix objectSupport plugin to get the correct result (zero-based month) #1089

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented Sep 28, 2020

dayjs({month: 1}) should return 2020-02-01 instead if 1970-01-01

  1. if no year provide, use the current year
  2. month should be 0-based

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1089 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1089   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines         1546      1547    +1     
  Branches       328       328           
=========================================
+ Hits          1546      1547    +1     
Impacted Files Coverage Δ
src/plugin/objectSupport/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51360dd...a5424f3. Read the comment docs.

@iamkun
Copy link
Owner Author

iamkun commented Sep 28, 2020

This should be a breaking change, let make it from 1.8.x to 1.9.1

@iamkun iamkun merged commit f95ac15 into dev Sep 28, 2020
iamkun pushed a commit that referenced this pull request Sep 28, 2020
## [1.9.1](v1.9.0...v1.9.1) (2020-09-28)

### Bug Fixes

* Fix objectSupport plugin to get the correct result (zero-based month) ([#1089](#1089)) ([f95ac15](f95ac15))
@iamkun
Copy link
Owner Author

iamkun commented Sep 28, 2020

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun deleted the fix/object-support branch October 2, 2020 07:38
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.9.1](iamkun/dayjs@v1.9.0...v1.9.1) (2020-09-28)

### Bug Fixes

* Fix objectSupport plugin to get the correct result (zero-based month) ([#1089](iamkun/dayjs#1089)) ([f95ac15](iamkun/dayjs@f95ac15))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.9.1](iamkun/dayjs@v1.9.0...v1.9.1) (2020-09-28)

### Bug Fixes

* Fix objectSupport plugin to get the correct result (zero-based month) ([#1089](iamkun/dayjs#1089)) ([f95ac15](iamkun/dayjs@f95ac15))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
## [1.9.1](iamkun/dayjs@v1.9.0...v1.9.1) (2020-09-28)

### Bug Fixes

* Fix objectSupport plugin to get the correct result (zero-based month) ([#1089](iamkun/dayjs#1089)) ([f95ac15](iamkun/dayjs@f95ac15))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant