Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all unit in OpUnitType is legal unit for add and subtract #1575

Closed
susiwen8 opened this issue Jul 13, 2021 · 1 comment · Fixed by #1576
Closed

Not all unit in OpUnitType is legal unit for add and subtract #1575

susiwen8 opened this issue Jul 13, 2021 · 1 comment · Fixed by #1576
Labels
released

Comments

@susiwen8
Copy link
Contributor

Describe the bug
OpUnitType contain some 'illegal' unit for add and subtract. According to doc.
I was misled by OpUnitType, thought date can be applied to subtract, but result was unexpected. Value wasn't changed. Took me sometime to figure it out.

Expected behavior
Correct TS params type for add and subtract unit.

Information

  • Day.js latest
  • OS: Mac0S
  • Browser latest Chrome
@susiwen8 susiwen8 mentioned this issue Jul 13, 2021
Merged
@iamkun
Copy link
Owner

iamkun commented Sep 10, 2021

🎉 This issue has been resolved in version 1.10.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: narrow type for add and subtract
2 participants
@iamkun @susiwen8