Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese (pt) and Brazilian Portuguese (pt-br) should have lowercase weekdays and months #1696

Closed
ftzi opened this issue Nov 13, 2021 · 2 comments
Labels

Comments

@ftzi
Copy link
Contributor

ftzi commented Nov 13, 2021

Describe the bug
As #274, Portuguese (pt) and Brazilian Portuguese (pt-br) have lowercase weekdays (sexta-feira, sábado etc) and months (janeiro, fevereiro, etc).

Other Romance languages are following their same lowercase rules:
https://github.com/iamkun/dayjs/blob/master/src/locale/es.js
https://github.com/iamkun/dayjs/blob/master/src/locale/it.js
https://github.com/iamkun/dayjs/blob/master/src/locale/fr.js

Seems that the author of pt/pt-br just followed the en pattern, that doesn't apply to us.

I will keep WeekdaysMin Do and in their uppercase format as it looks better when next to the other WeekdaysMin that begins with a number (, ...). If someone thinks it would be good to also change them to lowercase, feel free to discuss, open issue, PR, etc. Keeping it just for aesthetics.

Expected behavior
Lowercase weekdays and months

Sources
https://www.jn.pt/artes/dossiers/portugues-atual/maiusculas-eou-minusculas-3784419.html
https://www.infopedia.pt/$marco-ou-marco
https://blogs.correiobraziliense.com.br/dad/maiusculas-e-minusculas-meses-3/
https://blogs.correiobraziliense.com.br/dad/nome-de-mes-e-vira-lata/

Information

  • Day.js Version [e.g. v1.0.0] 1.10.7

I will also PR it.

@iamkun
Copy link
Owner

iamkun commented Feb 28, 2022

🎉 This issue has been resolved in version 1.10.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ftzi
Copy link
Contributor Author

ftzi commented Feb 28, 2022

Thanks! :)

@ftzi ftzi closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants