Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update it-ch.js #1829

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Update it-ch.js #1829

merged 2 commits into from
Apr 14, 2022

Conversation

maxhellwig
Copy link
Contributor

@maxhellwig maxhellwig commented Mar 14, 2022

RelativeTime locale strings have been taken from it.js.
Actually I'm not sure if its correct for users with it-ch locale but for me it looks like it locale has just been missing from it-ch

Any ideas or suggestions, beside from adding some additional tests for the formatting :-)

Kind regards
Max

Example has been taken from `it.js`.
Actually I'm not sure if its correct for users with `it-ch` locale but for me it looks like `it` locale has just been missing from `it-ch`

Any ideas?


Kind regards
Max
@maxhellwig
Copy link
Contributor Author

Compared it with moment.js it-ch.js and it seems reasonable.. :-)

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1829 (7d53d28) into dev (b045baf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #1829   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          180       180           
  Lines         2034      2034           
  Branches       524       524           
=========================================
  Hits          2034      2034           
Impacted Files Coverage Δ
src/locale/it-ch.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b045baf...7d53d28. Read the comment docs.

@maxhellwig
Copy link
Contributor Author

Some tests have been added to compare localised formats with moment.js.

@iamkun
Copy link
Owner

iamkun commented Apr 14, 2022

Thanks

@iamkun iamkun merged commit 8e6d11d into iamkun:dev Apr 14, 2022
@maxhellwig maxhellwig deleted the patch-2 branch April 14, 2022 13:08
iamkun pushed a commit that referenced this pull request Apr 15, 2022
## [1.11.1](v1.11.0...v1.11.1) (2022-04-15)

### Bug Fixes

* add Bengali (Bangladesh) [bn-bd] locale ([#1806](#1806)) ([840ed76](840ed76))
* refactor replace deprecated String.prototype.substr() ([#1836](#1836)) ([627fa39](627fa39))
* Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](#1831)) ([4e2802c](4e2802c))
* update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](#1829)) ([8e6d11d](8e6d11d))
* update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](#1848)) ([a597d0b](a597d0b))
* update locale bo [Tibetan]: corrected the orders in formats ([#1823](#1823)) ([e790516](e790516))
@iamkun
Copy link
Owner

iamkun commented Apr 15, 2022

🎉 This PR is included in version 1.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15)

### Bug Fixes

* add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76))
* refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39))
* Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c))
* update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d))
* update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b))
* update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15)

### Bug Fixes

* add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76))
* refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39))
* Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c))
* update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d))
* update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b))
* update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15)

### Bug Fixes

* add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76))
* refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39))
* Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c))
* update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d))
* update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b))
* update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants