Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ss [plural for seconds] #223

Closed
diomed opened this issue Jun 1, 2018 · 8 comments
Closed

ss [plural for seconds] #223

diomed opened this issue Jun 1, 2018 · 8 comments

Comments

@diomed
Copy link
Contributor

diomed commented Jun 1, 2018

I don't see string for plural of seconds anywhere in translations,
and I'm pretty sure if there's d, dd and m, mm, and h, hh, there
should also be s, ss

@iamkun
Copy link
Owner

iamkun commented Jun 1, 2018

Yes, we have this.

s 0-59 The second
ss 00-59 The second, 2-digits
SSS 000-999 The millisecond, 3-digits

@diomed
Copy link
Contributor Author

diomed commented Jun 2, 2018

it isn't in any translate file however.
it should be, right?

@iamkun
Copy link
Owner

iamkun commented Jun 4, 2018

@iamkun iamkun mentioned this issue Jun 5, 2018
@aalises
Copy link
Contributor

aalises commented Jun 5, 2018

@diomed @iamkun we don't need the 'ss' string as our RelativeTime plugin does not use it. As differentiating from 1 second to 9 seconds is quite specific, we just provide the 'few seconds' generalization for this case. See how the locales are written.

@iamkun
Copy link
Owner

iamkun commented Jun 5, 2018

@aalises I skipped the ss string in our RelativeTime plugin just because I want to keep the same behavior as moment.js. However, if we think it necessary, we could add it back.

@aalises
Copy link
Contributor

aalises commented Jun 5, 2018

@iamkun I don't think it's necessary to be fair 👍

@prantlf
Copy link
Contributor

prantlf commented Sep 13, 2018

@aalises, using just s with "a couple of seconds" is fine. I agree, that there's no need to make it more complicated to "count the seconds".

But there is a problem with using your localization functionality in real-world applications, which are not in English. Assuming, that "in a couple of seconds" and "a couple of seconds ago" uses the same common text "a couple of seconds" is wrong. Other languages need to apply declension specific to preposition used. I opened #302 about it.

@iamkun
Copy link
Owner

iamkun commented Feb 2, 2019

discussion 302

@iamkun iamkun closed this as completed Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants