Getter/setter plural aliases missing (e.g. hour() works but hours() does not)

[niftylettuce]

#58 (comment)

[iamkun]

It's easy to add this as a plugin, but is it necessary?

[niftylettuce]

@iamkun I definitely think so. You have plural support in diff, e.g.

dayjs/test/display.test.js

Line 180 in 4c862f6

it('diff -> in seconds, minutes, hours, days, weeks, months, quarters, years ', () => {

.

[iamkun]

yes, that plural for unit

[niftylettuce]

I think that if you have plural and singular in some parts of this library, it should be consistent everywhere else. Having a MomentJS advertised compatible API should add this in - especially since it's so easy to add it in as you say.

[iamkun]

I'll pending this issue for more discussion. The top 1 reason is always this total bundle size. I don't want to add even 1 more byte for features that are not that important.

[niftylettuce]

Any chance we could get this in as a feature? I'd gladly tip. I don't think it'd add much to make it so plural versions work, and the developer experience would greatly be in favor of this, it would also be in parity with moment, and make it easier for people to switch massive codebases over.

[iamkun]

Agree to add it as a plugin, but not in the main bundle.

[iamkun]

🎉 This issue has been resolved in version 1.8.33 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀