Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using pitchy with jest v28 #110

Closed
glend1 opened this issue Jul 30, 2022 · 1 comment
Closed

using pitchy with jest v28 #110

glend1 opened this issue Jul 30, 2022 · 1 comment

Comments

@glend1
Copy link
Contributor

glend1 commented Jul 30, 2022

I have created a question on stackoverflow detailing my problem.

But the short version is that this library doesn't work when importing using jest v28. I have fixed this by changing the package.json from this library

From;

...
  "exports": {
    "./package.json": "./package.json",
    ".": {
      "types": "./index.d.ts",
      "import": "./index.js"
    }
  },
...

To;

...
  "exports": {
    "./package.json": "./package.json",
    ".": {
      "default": "./index.js"
    }
  },
...

I wasn't able to find any documentation about what exports is supposed to do but this style seems more inline with other packages i've looked at.

@ianprime0509
Copy link
Owner

Thank you for pointing this out! I merged #112 which you opened, and it'll be included in the automated next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants