Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Android: Looking for helpers August 13-17 to participate #2047

Closed
thesunny opened this issue Aug 7, 2018 · 4 comments
Closed

Fix for Android: Looking for helpers August 13-17 to participate #2047

thesunny opened this issue Aug 7, 2018 · 4 comments

Comments

@thesunny
Copy link
Collaborator

thesunny commented Aug 7, 2018

I promised in #725 (comment) to spend a week in August to get Android working with Slate. I'll start on Monday August 13 and am looking for collaborators. I'll probably start around 10-11AM PST.

Here's how you can help:

  • Provide Live Feedback Aug 13-17: To help, just read comments posted in this issue during August 13-17 and provide any insights or ideas. In order to provide better feedback, I recommend reading the relevant resources below (you can skip "Roadmap"). It's a bit of a personal psychology hack but I think better when there is back and forth or even if I have to describe a problem knowing somebody is actually listening.
  • Active Contribution: I would love it if somebody could actively collaborate with me to work through issues on the week of. You should be willing to set up an Android test environment locally https://thesunny.gitbook.io/slate/v/doc-dev-guides/contributing/android-dev-guide

Here are the relevant resources for background reading (you can skip Roadmap but I leave it here for context)

First Approach
The most progress was made from the PR #1935 contributed by @mattkrick who ended up using another Editor but the PR is the closest we've come.

At the time, I recommended declining the PR because depending on whether we had a setTimeout delay or not, it worked in normal gboard but not IME or visa versa.

My first approach will be to see if we can detect IME mode and provide a different delay setting depending on whether IME is active or not.

@ianstormtaylor @slapbox @mattkrick @zhujinxuan @zaaack @oyeanuj @javan @nathanfu88 @danburzo

@Nantris
Copy link
Contributor

Nantris commented Aug 7, 2018

@thesunny are you planning to use @mattkrick's work as a starting point? Specifically: https://github.com/mattkrick/slate/tree/slate-fast

I think this is a great place to start and probably further along than #1935

@thesunny
Copy link
Collaborator Author

thesunny commented Aug 7, 2018

@slapbox Yes, I believe #1935 is from slate-fast but for clarity, I'll start with the latest version.

@thesunny
Copy link
Collaborator Author

Just a heads up @slapbox that I'm going to start by filling in the missing bits in the issue posted here #2062 as I think helping Ian is the fastest way to move this forward.

If you or anybody wants to jump in, we can coordinate doing this. I'm basically following @ianstormtaylor template and posting things in DropBox Paper.

@thesunny
Copy link
Collaborator Author

Closing this issue. There is progress going on and all the updates are happening in #2062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants