Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs use useMemo when useRef may be more appropriate #3233

Closed
dminkovsky opened this issue Dec 4, 2019 · 2 comments
Closed

Docs use useMemo when useRef may be more appropriate #3233

dminkovsky opened this issue Dec 4, 2019 · 2 comments

Comments

@dminkovsky
Copy link

dminkovsky commented Dec 4, 2019

Given that useMemo does not provide a semantic guarantee constancy, wouldn't something like useConstant be more appropriate in the new Installing Slate docs. This reference should be truly constant, right?

@dminkovsky dminkovsky changed the title Docs use useMemo when useConstant may be more appropriate Docs use useMemo when useRef may be more appropriate Dec 4, 2019
@ianstormtaylor
Copy link
Owner

Closing in favor of #3198

@dminkovsky
Copy link
Author

Heh, should have checked! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants