Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug: German Keyboard backtick isn't recognized in onChange event; crashes editor when using placeholder #4001

Open
marcusellison opened this issue Nov 27, 2020 · 1 comment · May be fixed by #5407

Comments

@marcusellison
Copy link

Do you want to request a feature or report a bug?

🐞 Bug

What's the current behavior?

The first keypress of a german backtic fails to register an onChange event which creates different slate and dom points.

From sandbox: https://codesandbox.io/s/slate-reproductions-forked-m8qpg?file=/package.json

  • delete default text until placeholder displays
  • make sure MacOS german keyboard is enabled
  • type a backtick (on my mac u.s. keyboard this is the "=" key)
  • then type any other character

Editor crashes with error Cannot resolve a Slate point from DOM point: [object Text],1

This can also be reproduced in slate.js examples

Slate: 0.59.0
Browser: Chrome Version 86.0.4240.198 (Official Build) (x86_64)
OS: Mac 11.01

What's the expected behavior?

  • The first instance of typing a german backtick should register an onChange event
  • The editor should not crash when placeholder is enabled.
@PibeG
Copy link

PibeG commented Nov 30, 2020

Seems like #3437 would solve this issue.

@zbeyens zbeyens linked a pull request Apr 27, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants