Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double characters when using a tag in newer version of react slate #4911

Closed
idChef opened this issue Mar 24, 2022 · 2 comments · Fixed by #4948
Closed

Double characters when using a tag in newer version of react slate #4911

idChef opened this issue Mar 24, 2022 · 2 comments · Fixed by #4948
Labels

Comments

@idChef
Copy link

idChef commented Mar 24, 2022

Description
Using a tag as inline, block or mark results in double characters inputting when writting at the end of that node similar to a fixed #4445 issue. I have tested and the problem does not appear on "slate": "0.57.1", "slate-react": "0.57.1" so it must be with some new additions to the code.

Recording

Nagranie.z.ekranu.2022-03-24.o.01.00.30.mov

Sandbox
Link to my sandbox

Steps
To reproduce the behaviour:

  1. focus on text
  2. Click add link
  3. Write at the end of the block
  4. Double characters appear and result in crash when trying to select them

Expectation
There should be no double characters appearing when using a tag

Environment

  • Slate Version: "slate": "0.73.1", "slate-react": "0.74.1"
  • Operating System: macOS
  • Browser: Chrome

If anybody knows any workaround for now then I would be glad. I will also try figuring out which version implemented this.

@idChef idChef added the bug label Mar 24, 2022
@idChef
Copy link
Author

idChef commented Mar 24, 2022

I checked each version of slate-react. The last working version with the a tag is 0.65.3. When I change to 0.66.0 the bug appears. Weird cuz #4445 was supposed to fix that problem

@idChef
Copy link
Author

idChef commented Mar 28, 2022

I managed to create links that work and bypass this problem by looking at the inline example. This behaviour is still weird for me but it's not that crucial to fix I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant