You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
AndroidEditable doesn't react on readOnly prop change. If it was set to true when AndroidEditable was initialized it will remain in read only mode. In browser it looks like text being inserted, but no updates in editor happens.
Steps
To reproduce the behavior:
Start editor with readOnly set to true
Type in any text
console.log(editor.children) to see that there is no change
Expectation
AndroidEditable should be able to react on change of readOnly prop after initialization.
Environment
Slate-React 0.79.0
Android Emulator API 31
Chrome
Context
Error is caused by dependency list in isomorphicLayoutEffect adding listener to beforeinput event in android-editable.tsx
onDOMBeforeInput does update when readOnly changes, but the effect doesn't react to that.
This should work fine, unless there are reasons i miss for using specifically propsOnDOMBeforeInput.
The text was updated successfully, but these errors were encountered:
Happening to me as well, you even can reproduce it by changing to an Android device from dev tools in a desktop Chrome, because it'll use AndroidEditable.
@belianikov@BitPhinix I've seen the whole Android thing is merged, which it's mentioning this ticket, but I think this is still happening, at least in my environment, and since this is still opened I wasn't sure. Is this still a thing?
Description
AndroidEditable doesn't react on readOnly prop change. If it was set to true when AndroidEditable was initialized it will remain in read only mode. In browser it looks like text being inserted, but no updates in editor happens.
Steps
To reproduce the behavior:
Expectation
AndroidEditable should be able to react on change of readOnly prop after initialization.
Environment
Context
Error is caused by dependency list in isomorphicLayoutEffect adding listener to beforeinput event in android-editable.tsx
onDOMBeforeInput does update when readOnly changes, but the effect doesn't react to that.
This should work fine, unless there are reasons i miss for using specifically propsOnDOMBeforeInput.
The text was updated successfully, but these errors were encountered: