Meeting - 2/6/2019

[iansu]

Agenda

• Triaging issues
  • Improving and documenting our triage and escalation process (@mrmckeb)
    • Perhaps setting community SLAs
    • Escalation in case of emergencies? Example: "Failed to minify the bundle" error on build (related to Terser) facebook/create-react-app#6334
  • Formalize and document the issue triage process (in this repo?)
  • Make better use of Projects in GitHub for planning and working through issues and PRs
• PRs
  • Standardize and document process for reviewing and merging PRs
    • Number of required approvals?
    • Approvals from code owners?
  • Discuss any breaking changes or new features with other maintainers
  • Bugfixes, docs updates, refinements to existing features probably don't need consensus
• Maintainers
  • Make sure we have shared contact info for all maintainers
  • Make sure all active maintainers are on Discord
  • Write up onboarding documentation and keep in this repo
• Technical
  • A package.json key for CRA options (maybe "react-app"). This could enable a lot of features that benefit parts, but not all of the community. (@mrmckeb)
    • Related: Discussing Advanced Configuration Options facebook/create-react-app#6303
  • The possibility to add custom template support (@mrmckeb)
  • Extending webpack/eslint/babel configs
  • Hooks!
  • Issues
    • Add box-sizing: border-box to all elements by default facebook/create-react-app#6348
    • Allow react-scripts test --no-watch facebook/create-react-app#6285
• Project
  • Jest is an interesting example
    • Facebook Open Source project
    • Has its own GitHub org
    • Uses Open Collective to raise money
    • Pays bounties to users for implementing features

Attendees

• @iansu
• @Timer
• @ianschmitz
• @mrmckeb
• @petetnt

Notes

• Issues
  • Document triaging process in this repo
  • If you have questions about an issue post it on Discord
  • Use a Project/Milestone to track issues that need further triage
    • Projects give you some automation
• PRs
  • Document process
    • Have at least two approvals for breaking changes and new features
  • Discuss breaking changes on Discord
  • Use codeowners file
    • Maybe make everyone a code owner for packages, require one approval
      • We will need someone from Facebook to enable this setting for us
• Maintainers
  • Share contact info
  • Create an onboarding document in this repo
• Technical
  • Config
    • Don't want to open up webpack config
    • It would be nice to consolidate environment variable config and flags
    • Don't want to add a config file or key to package.json at this time. Revisit if we start adding more environment variables.
  • Templates
    • Templates should indicate which version of CRA they are compatible with
      • Use peerDependencies
    • Talk to popular projects about creating their own templates (redux, storybook, etc.)
    • Templates include their own README
    • Split our existing templates out into npm packages
    • Directory of templates?
      • Maybe. Defer until later
  • Warn when webpack config is modified
    • Freeze the config object and warn if it is changed
    • Display a warning in the console if the config is changed
      • Direct people to whatever tool they have used to modify it
  • Hooks
    • Are supported by just using latest version of React
    • Need to add ESLint plugin
      • This will be a part of 3.0
  • 3.0
    • Hooks ESLint plugin
    • Jest 24
    • jsconfig.json?
      • Is this ready
    • What else?
      • Create a Project in GitHub to track
• Project
  • Starting an Open Collective seems like a good idea
    • Need to figure out how best to manage this
  • Benefits of having our own GitHub org do seem compelling

Previous Action Items

• Make this a regular meeting (@iansu)
• Give maintainers access to this repo (@iansu)
• Give maintainers access to Netlify (@iansu)
• Improve labels
• Add a "Troubleshooting" section to the docs for common install issues
• Add additional ignored labels to Stale Bot (@iansu)
• Automate docs deploy (@iansu)
• Get Algolia credentials (@iansu)

Action Items

• Improve labels
• Add a "Troubleshooting" section to the docs for common install issues
• Automate docs deploy (@iansu)
• Get Algolia credentials (@iansu)
• Create a shared folder in Google Docs for maintainers (@iansu)
• Document triaging process (@iansu)
• Document PR process (@iansu)
• Create maintainer onboarding document (@iansu)
• Try to get a hold of Jack (@bugzpodder) and get him back on Discord (@Timer)
• Prototype template behaviour with dependencies, etc. (@mrmckeb)
• Create a GitHub Project for 3.0 (@iansu)
• Create a GitHub Project for issue triaging (@iansu)
• Prototype webpack config freezing/warning (@Timer)
• Set up CODEOWNERS (@iansu)

Details

February 6, 2019 10:00am Pacific
https://www.timeanddate.com/worldclock/fixedtime.html?msg=Create+React+App+maintainers+meeting&iso=20190206T18&p1=1440

Zoom: https://zoom.us/j/163553316

[mrmckeb]

As I unfortunately missed the meeting (sorry again), I'd like to carry over my notes from the last meeting.

I'd also like to further the config discussion... I think a package.json config could solve a lot of issues for a lot of people.

[ianschmitz]

I was unable to attend but I'm going to explore other CI providers to see if we can improve our build pipeline

[bugzpodder]

@iansu Sorry, wasn't aware of any of these until now. Will get discord working again.

[ianschmitz]

Did we make a decision with regards to facebook/create-react-app#6348?

[mrmckeb]

@ianschmitz It's a no for now, well think about it more after templates.