-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recompile for python 3.7 #151
Comments
@ZeerakW Has fastFM been working with 3.7 before or is a more recent cython need to compile fastFM for 3.7? |
I'm not sure if it's been working for 3.7 before, just came across your library a couple of days ago. But it seems that specifically Cython 0.29 has been used so a more recent version of cython is needed. I managed to compile it using Cython 0.29 but I wasn't sure where to submit a PR. I think in fastFM-core, but not sure - if it is in core then let me know and I can submit a PR later today. |
@ZeerakW
It's not, core contains only the C code. |
The only changes that are happening are in core so I'm not sure what the difference is :/.
|
@ZeerakW
This are just the created binary files that are not included into the repo. So the conclusion seems to be that: for python 3.7 the Cython requirement needs to be raised to 0.29 |
Yup, exactly. :) |
It'd be very cool if a wheel was pushed for Python 3.7 on PyPI |
FastFM fails to install on python 3.7 due to updates in Cython. I'd put in a pull request, but due to the split between FastFM-core and fastFM I'm not sure where to submit the PR.
Steps to reproduce issue:
Steps to fix:
The text was updated successfully, but these errors were encountered: