IBX-9266: Applied review remarks

Author: barw4

src/bundle/Resources/config/routing_rest.yaml

@@ -131,8 +131,8 @@ ibexa.rest.image.download:
 # Site Access
 #
 
-ibexa.rest.siteaccess.load_for_location:
-    path: /siteaccess/load-non-admin-for-location/{locationId}
+ibexa.rest.site_access.load_for_location:
+    path: /site-access/load-non-admin-for-location/{locationId}
     controller: 'Ibexa\Bundle\AdminUi\Controller\SiteAccess\SiteAccessController::loadNonAdminSiteAccessesForLocation'
     methods: [GET]
     options:

src/lib/REST/Output/ValueObjectVisitor/SiteAccess/SiteAccessesListVisitor.php

@@ -29,9 +29,6 @@ public function visit(Visitor $visitor, Generator $generator, $data): void
             $generator->startValueElement('name', $siteAccess->name);
             $generator->endValueElement('name');
 
-            $generator->startValueElement('provider', $siteAccess->provider);
-            $generator->endValueElement('provider');
-
             $generator->endObjectElement('SiteAccess');
         }
         $generator->endList('values');

tests/integration/REST/GetSiteAccessesListTest.php

@@ -11,7 +11,7 @@
 use Ibexa\Contracts\Test\Rest\Request\Value\EndpointRequestDefinition;
 
 /**
- * Coverage for /siteaccess/load-non-admin-for-location/{locationId} REST endpoint.
+ * Coverage for /site-access/load-non-admin-for-location/{locationId} REST endpoint.
  */
 final class GetSiteAccessesListTest extends BaseAdminUiRestWebTestCase
 {
@@ -44,7 +44,7 @@ protected static function getEndpointsToTest(): iterable
         foreach (self::REQUIRED_FORMATS as $format) {
             yield new EndpointRequestDefinition(
                 'GET',
-                '/api/ibexa/v2/siteaccess/load-non-admin-for-location/2',
+                '/api/ibexa/v2/site-access/load-non-admin-for-location/2',
                 'SiteAccessesList',
                 "application/vnd.ibexa.api.SiteAccessesList+$format",
                 ['HTTP_X-SiteAccess' => 'admin'],

tests/integration/Resources/REST/Schemas/SiteAccessesList.json

@@ -19,15 +19,11 @@
                 },
                 "name": {
                   "type": "string"
-                },
-                "provider": {
-                  "type": "string"
                 }
               },
               "required": [
                 "_media-type",
-                "name",
-                "provider"
+                "name"
               ]
             }
           ]

tests/integration/Resources/REST/Schemas/SiteAccessesList.xsd

@@ -7,7 +7,6 @@
                     <xs:complexType>
                         <xs:sequence>
                             <xs:element name="name" type="xs:string" />
-                            <xs:element name="provider" type="xs:string" />
                         </xs:sequence>
                         <xs:attribute name="media-type" type="xs:string" use="required" />
                     </xs:complexType>

tests/integration/Resources/REST/Snapshots/SiteAccessesList.json

@@ -4,28 +4,23 @@
     "values": [
       {
         "_media-type": "application/vnd.ibexa.api.SiteAccess+json",
-        "name": "__default_site_access__",
-        "provider": "Ibexa\\Core\\MVC\\Symfony\\SiteAccess\\Provider\\StaticSiteAccessProvider"
+        "name": "__default_site_access__"
       },
       {
         "_media-type": "application/vnd.ibexa.api.SiteAccess+json",
-        "name": "__second_site_access__",
-        "provider": "Ibexa\\Core\\MVC\\Symfony\\SiteAccess\\Provider\\StaticSiteAccessProvider"
+        "name": "__second_site_access__"
       },
       {
         "_media-type": "application/vnd.ibexa.api.SiteAccess+json",
-        "name": "ger",
-        "provider": "Ibexa\\Core\\MVC\\Symfony\\SiteAccess\\Provider\\StaticSiteAccessProvider"
+        "name": "ger"
       },
       {
         "_media-type": "application/vnd.ibexa.api.SiteAccess+json",
-        "name": "eng",
-        "provider": "Ibexa\\Core\\MVC\\Symfony\\SiteAccess\\Provider\\StaticSiteAccessProvider"
+        "name": "eng"
       },
       {
         "_media-type": "application/vnd.ibexa.api.SiteAccess+json",
-        "name": "ku6\"H",
-        "provider": "Ibexa\\Core\\MVC\\Symfony\\SiteAccess\\Provider\\StaticSiteAccessProvider"
+        "name": "ku6\"H"
       }
     ]
   }

tests/integration/Resources/REST/Snapshots/SiteAccessesList.xml

@@ -2,22 +2,17 @@
 <SiteAccessesList media-type="application/vnd.ibexa.api.SiteAccessesList+xml">
     <SiteAccess media-type="application/vnd.ibexa.api.SiteAccess+xml">
         <name>__default_site_access__</name>
-        <provider>Ibexa\Core\MVC\Symfony\SiteAccess\Provider\StaticSiteAccessProvider</provider>
     </SiteAccess>
     <SiteAccess media-type="application/vnd.ibexa.api.SiteAccess+xml">
         <name>__second_site_access__</name>
-        <provider>Ibexa\Core\MVC\Symfony\SiteAccess\Provider\StaticSiteAccessProvider</provider>
     </SiteAccess>
     <SiteAccess media-type="application/vnd.ibexa.api.SiteAccess+xml">
         <name>ger</name>
-        <provider>Ibexa\Core\MVC\Symfony\SiteAccess\Provider\StaticSiteAccessProvider</provider>
     </SiteAccess>
     <SiteAccess media-type="application/vnd.ibexa.api.SiteAccess+xml">
         <name>eng</name>
-        <provider>Ibexa\Core\MVC\Symfony\SiteAccess\Provider\StaticSiteAccessProvider</provider>
     </SiteAccess>
     <SiteAccess media-type="application/vnd.ibexa.api.SiteAccess+xml">
         <name>ku6&quot;H</name>
-        <provider>Ibexa\Core\MVC\Symfony\SiteAccess\Provider\StaticSiteAccessProvider</provider>
     </SiteAccess>
 </SiteAccessesList>