Send notifications for feed expirations

[landonreed]

Issue by evansiroky
Wednesday Nov 28, 2018 at 00:37 GMT
Originally opened as catalogueglobal#126

---

Implementation to resolve #121.

Will send a 1 week warning email and an email on the day of an expiration.

Also has some refactoring of commonly shared code and fixes #123.

---

evansiroky included the following code: https://github.com/catalogueglobal/datatools-server/pull/126/commits

[landonreed]

Comment by landonreed
Thursday Nov 29, 2018 at 16:33 GMT

---

@evansiroky, one other comment I have: can you run the cancel notifications method when a feed source is deleted (i.e., within FeedSource#delete)? While you're at it, please do the same for cancelling auto fetch when a project is deleted. Thanks!

[landonreed]

Comment by evansiroky
Monday Dec 03, 2018 at 03:26 GMT

---

@landonreed The method for deleting a project will call the feedsource delete method which will call the feedversion delete method which now recalculates the feed expiration notifications, so your request for adding to the delete methods should be needed.

[landonreed]

Comment by evansiroky
Tuesday Dec 04, 2018 at 20:13 GMT

---

Requested changes implemented. Should be ready for review and/or approval.

[landonreed]

Comment by landonreed
Tuesday Dec 11, 2018 at 19:02 GMT

---

OK, #130 has been merged into this PR. I think we can call this complete now.