Flow type components

[landonreed]

Issue by landonreed
Tuesday Aug 21, 2018 at 17:02 GMT
Originally opened as catalogueglobal#235

---

Add flow typing to library (nearly) all components. Notable components this avoids are some of the modal components, which need to be refactored altogether because they rely heavily on refs and accept state/props through their open method, and the Settings components, which should see a refactor in #41.

This PR raises the flow coverage to a semi-respectable 76%.

---

landonreed included the following code: https://github.com/catalogueglobal/datatools-ui/pull/235/commits

[landonreed]

Comment by codecov-io
Tuesday Aug 21, 2018 at 17:45 GMT

---

Codecov Report

Merging #235 into dev will decrease coverage by 0.05%.
The diff coverage is 0.38%.

@@           Coverage Diff            @@
##             dev    #235      +/-   ##
========================================
- Coverage    3.6%   3.55%   -0.06%     
========================================
  Files        327     325       -2     
  Lines      11839   12035     +196     
  Branches    4202    4297      +95     
========================================
+ Hits         427     428       +1     
- Misses      9373    9526     +153     
- Partials    2039    2081      +42

Impacted Files	Coverage Δ
lib/editor/reducers/index.js	0% <ø> (ø)	⬆️
lib/admin/reducers/organizations.js	27.77% <ø> (ø)	⬆️
lib/editor/reducers/settings.js	29.41% <ø> (ø)	⬆️
lib/alerts/reducers/alerts.js	10.95% <ø> (ø)	⬆️
lib/editor/reducers/mapState.js	28.57% <ø> (ø)	⬆️
lib/signs/containers/ActiveSignEditor.js	0% <ø> (ø)	⬆️
lib/manager/containers/ActiveFeedSourceViewer.js	0% <ø> (ø)	⬆️
lib/manager/actions/status.js	0% <ø> (ø)	⬆️
lib/manager/components/ProjectsList.js	0% <ø> (ø)	⬆️
lib/editor/util/map.js	10% <ø> (ø)	⬆️
... and 168 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ccc70...17fd1cf. Read the comment docs.

[landonreed]

Comment by landonreed
Thursday Aug 23, 2018 at 18:07 GMT

---

OK, @evansiroky. I've addressed all of your comments. Good to merge?